Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not render INAV logo on DJI compat mode #10055

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Conversation

DzikuVx
Copy link
Member

@DzikuVx DzikuVx commented May 18, 2024

No description provided.

@DzikuVx DzikuVx added this to the 8.0 milestone May 18, 2024
@MrD-RC
Copy link
Collaborator

MrD-RC commented May 18, 2024

I don't think we should add any more changes to osd.c for DJI.

@DzikuVx
Copy link
Member Author

DzikuVx commented May 19, 2024

I wish we could have a single OSd implementation but we don't. And the fact is that DJI is the biggest FPV system on the market. It will be beneficial for our pilots is we make their live a little better in the process.

@MrD-RC
Copy link
Collaborator

MrD-RC commented May 19, 2024

What difference will it make other than spacing? If there are no logo characters, they will just see ? or a blank space.

No other FPV system on the market requires changes to osd.c. We should not bastardise it for a single system. It just adds bloat for everyone who doesn't use DJI.

Paweł. Your pole showed that 48% use DJI. Not that 48% use O3. Being generous and saying half are. That's 22% of FPV pilots. I know plenty of people who are using the old system because they don't want to lose WTFOS.

@DzikuVx DzikuVx merged commit 864bb15 into master Jun 4, 2024
14 checks passed
@DzikuVx DzikuVx deleted the dzikuvx-no-inav-logo-on-dji branch June 4, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants