-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorder boxmodes for flight mode priority #10047
Conversation
Why not add an additional field to blackbox? And will you also provide a PR for INAV blackbox-tools as required? |
Do you mean a separate field for actual "flight" modes and another field for all other modes ?
I have something that works. Not sure if it's the best way of doing it ... but it works. |
I was thinking of maybe an
There is an example in |
I was thinking maybe it's overkill to include all the modes given most of the remainder aren't that useful for debugging etc.
I'll do a PR for the change I made, take it from there. |
Will this impact 7->8 upgrades? If so, we should mention it in the release notes. |
Shouldn't have any impact on users other than certain modes selections such as Cruise being recorded in log files. |
Replaced by #10093. |
Reorders boxmodes to prioritise flight modes within the first 32 entries. This ensures flight modes and more significant modes are included in blackbox flight logs.
Numbering has been removed from the
boxId_e
enum since it doesn't appear to serve any useful purpose.Doesn't appear to cause any issues from testing ...
Change affects Blackbox Explorer which will need updating to ensure correct boxmode mapping is used depending on INAV version (Ref Blackbox change iNavFlight/blackbox-log-viewer#101).