fix #228 (failures with quotes) #613
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the ChangeLog > * better apostrophe usage: > - WORDCHARS only with one of the Unicode or ASCII apostrophe > results extended word tokenization: both of them will be part of > the words (if they are inside: eg. word's, but not words'). > - convert Unicode apostrophes to ASCII ones for 8-bit dictionaries > (eg. English dictionaries), or for UTF-8 dictionaries only > with ASCII apostrophe supports (eg. French dictionaries). tokenization should treat interior apostrophes as part of words and exclude boundary apostrophes. However, the provided test fails the assertion.
Add `TextParser::wordchar_apostrophe` protected property to abstract queries that apostrophe is a `WORDCHAR`. Modify `TextParser::next_token` - in non word case, ignore `'\''` - in word case - substitute `TextParser::wordchar_apostrophe` - rewrite branches regarding apostrophe as a nested branches to introduce boolean variables `is_wordchar_apostrophe` & `is_end_apostrophe` to track whether a `WORDCHAR` apostrophe was encountered and whether it's at the end of a word - split the state transition branch into a separate statement so it can handle apostrophes
rename apostrophe test to apostrophe1 add apostrophe2 with `WORDCHARS ’`
add `TextParser::is_apostrophe` method to test whether current character is an apostrophe in non word case of `TextParser::next_token`, skip apostrophes
lmmarsano
changed the title
|
Hello @lmmarsano, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not fluent in C++, so close review & guidance or proceeding from where I started would probably be best.
This tries to fix #228
The master branch reports 40 failures in AppVeyor, which I made sure to preserve in this branch.
fixes #228 and related issues