Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image feature extraction task spec and widget #614

Closed
wants to merge 3 commits into from

Conversation

merveenoyan
Copy link
Contributor

cc @osanseviero as discussed

@merveenoyan
Copy link
Contributor Author

unfortunately I linted and formatted yet there's no change I could stage in the files

@coyotte508
Copy link
Member

The error is not in the lint but when building the types:

https://github.com/huggingface/huggingface.js/actions/runs/8613823630/job/23605959758?pr=614#step:6:104

packages/tasks prepare: QuickTypeError: Key ImageClassificationParameters not in schema object at image-feature-extraction-input#ImageClassificationParameters

Probably this line: "$ref": "#/$defs/ImageClassificationParameters" should be "$ref": "#/$defs/FeatureExtractionParameters"

@merveenoyan
Copy link
Contributor Author

I have made a frankenstein widget from parts of image classification and feature extraction widget 🧟‍♂️ help is very appreciated!

@merveenoyan merveenoyan changed the title Add image feature extraction task spec Add image feature extraction task spec and widget Apr 9, 2024
@mishig25
Copy link
Collaborator

mishig25 commented Apr 9, 2024

is there a screenshot of the widget ?

@merveenoyan
Copy link
Contributor Author

@mishig25 how can I get this up on my local to give you a screenshot? it should be text input and table output (like feature extraction but with image input)

@mishig25
Copy link
Collaborator

mishig25 commented Apr 9, 2024

let me know if this readme insutrctions work https://github.com/huggingface/huggingface.js/tree/main/packages/widgets#demo

"properties": {
"inputs": {
"description": "The input image data",
"type": "string"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"type": "string"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merveenoyan
Copy link
Contributor Author

Closing this PR since widgets are moved back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants