Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change to yiyi's address. #7981

Merged
merged 2 commits into from
May 28, 2024
Merged

change to yiyi's address. #7981

merged 2 commits into from
May 28, 2024

Conversation

sayakpaul
Copy link
Member

It's time.

@sayakpaul sayakpaul requested a review from yiyixuxu May 19, 2024 15:35
setup.py Outdated
@@ -261,7 +261,7 @@ def run(self):
keywords="deep learning diffusion jax pytorch stable diffusion audioldm",
license="Apache 2.0 License",
author="The Hugging Face team (past and future) with the help of all our contributors (https://github.com/huggingface/diffusers/graphs/contributors)",
author_email="patrick@huggingface.co",
author_email="yiyi@huggingface.co",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

patrick is still the primary author even though he does not maintain the library anymore
maybe we should get a diffusers@huggingface.co similar to transformers?https://github.com/huggingface/transformers/blob/616bb11d487aabc231bb230b245c42214ea4b254/setup.py#L431

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense. I changed it following Accelerate.

I think it makes sense to change it accordingly.

I will let you take the best call here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done changing to diffusers@huggingface.co

@sayakpaul sayakpaul requested a review from yiyixuxu May 21, 2024 06:03
@yiyixuxu yiyixuxu merged commit aa676c6 into main May 28, 2024
2 checks passed
@yiyixuxu yiyixuxu deleted the contact-email branch May 28, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants