Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signature Auth: add Signature-Auth-Context header #2762

Merged
merged 3 commits into from
May 24, 2024

Conversation

DavidSchinazi
Copy link
Contributor

No description provided.

@kazuho
Copy link
Contributor

kazuho commented Mar 19, 2024

Please correct me if I'm wrong, but IIUC, the crux of this PR is that to allow any client that can present a valid pair of Authorization and Signature-Auth-Context header fields to obtain a protected resource.

Assuming that if we would be allowing such behavior, I wonder why we need to require clients to export keys from TLS session, rather than just coming up with some arbitrary authentication context and present it to the server?

Or if it is the case that there are situations in which we have to require clients to use keys exported from TLS session, doesn't it mean that there are cases where servers must ignore Signature-Authentication-Context header field or drop it?

@DavidSchinazi
Copy link
Contributor Author

@kazuho no this is only for trusted intermediaries. If a server receives a Signature-Auth-Context header from an untrusted source then it drops it. That's somewhat mentioned on line 470, but I'll add normative text.

@DavidSchinazi DavidSchinazi merged commit b8dd944 into main May 24, 2024
2 checks passed
@DavidSchinazi DavidSchinazi deleted the sign_auth/intermediary branch May 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants