Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[connect-tcp] Adjust rules for target_host and target_port #2736

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[connect-tcp] Adjust rules for target_host and target_port #2736

wants to merge 2 commits into from

Conversation

bemasc
Copy link
Contributor

@bemasc bemasc commented Feb 14, 2024 •
edited

Changes:

  • s/tcp_port/target_port/ (aligning with connect-udp)
  • Remove support for multiple IPs

Fixes #2713 and #2714

@bemasc
[connect-tcp] Adjust rules for target_port
197b189 
Changes:

* s/tcp_port/target_port/ (aligning with connect-udp)
* Make IP lists comma-separated instead of RFC 6570 list types.

Fixes #2713 and #2714
This was referenced Feb 14, 2024
Closed
Closed
@bemasc bemasc added the connect-tcp draft-ietf-httpbis-connect-tcp label Feb 14, 2024
@bemasc bemasc changed the title [connect-tcp] Adjust rules for target_port [connect-tcp] Adjust rules for target_host and target_port Feb 15, 2024
@bemasc
Copy link
Contributor Author

bemasc commented Apr 11, 2024

@MikeBishop The discussion at IETF 119 leaned toward removing the multiple-IP mode entirely. Are you suggesting that we should keep it?

@MikeBishop
Copy link
Contributor

This PR contains two changes; I'm not making a suggestion with regard to multiple-IP mode, but I think aligning the variable names in the template makes sense. Did both get dropped, or is that being discarded because it's in the same PR?

@bemasc
Copy link
Contributor Author

bemasc commented Apr 15, 2024

OK, I've updated this PR to also drop the multiple-IP support entirely.

MikeBishop
MikeBishop reviewed Apr 15, 2024
View reviewed changes
draft-ietf-httpbis-connect-tcp.md
Comment on lines 54 to 55

Classic HTTP CONNECT proxies can be used to reach a target host that is specified as a domain name or an IP address. However, because only a single target host can be specified, proxy-driven Happy Eyeballs and cross-IP fallback can only be used when the host is a domain name. For IP-targeted requests to succeed, the client must know which address families are supported by the proxy via some out-of-band mechanism, or open multiple independent CONNECT requests and abandon any that prove unnecessary.

## Overview
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that target_host can contain either an IP address or a DNS name, this text still seems relevant to the overall doc. Is the removal deliberate, or was the text relocated?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is deliberately removed, as it's no longer a problem that this draft attempts to address.

DavidSchinazi
DavidSchinazi approved these changes Apr 15, 2024
View reviewed changes
Copy link
Contributor

@DavidSchinazi DavidSchinazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates based on the discussion at 119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeBishop MikeBishop MikeBishop approved these changes

@DavidSchinazi DavidSchinazi DavidSchinazi approved these changes

@tfpauly tfpauly Awaiting requested review from tfpauly

Assignees
No one assigned
Labels
connect-tcp draft-ietf-httpbis-connect-tcp
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

connect-tcp: use target_port instead of tcp_port
3 participants
@bemasc @MikeBishop @DavidSchinazi