Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect-tcp: target_host is under-defined #2714

Open
DavidSchinazi opened this issue Jan 25, 2024 · 1 comment
Open

connect-tcp: target_host is under-defined #2714

DavidSchinazi opened this issue Jan 25, 2024 · 1 comment
Assignees
@bemasc
Labels
connect-tcp draft-ietf-httpbis-connect-tcp

Comments

@DavidSchinazi
Copy link
Contributor

The target_host variable is only described vaguely. It should be defined more rigorously. For example, it doesn't specify whether IPv6 scope IDs are allowed or not. I'd recommend reusing the text from RFC 9298.
@DavidSchinazi DavidSchinazi added the connect-tcp draft-ietf-httpbis-connect-tcp label Jan 25, 2024
bemasc added a commit that referenced this issue Jan 25, 2024
@bemasc
[connect-tcp] Define syntax more precisely
af67de2 
The language here is adapted from RFC 9298.

Fixes #2714
@bemasc bemasc mentioned this issue Jan 25, 2024
Closed
@bemasc
Copy link
Contributor

bemasc commented Jan 25, 2024

OK, I've opened #2719 to make the definition more rigorous.

@bemasc bemasc self-assigned this Jan 25, 2024
bemasc added a commit that referenced this issue Feb 14, 2024
@bemasc
[connect-tcp] Adjust rules for target_port
3b80ece 
Changes:

* s/tcp_port/target_port/ (aligning with connect-udp)
* Make IP lists comma-separated instead of RFC 6570 list types.

Fixes #2713 and #2714
bemasc added a commit that referenced this issue Feb 14, 2024
@bemasc
[connect-tcp] Adjust rules for target_port
197b189 
Changes:

* s/tcp_port/target_port/ (aligning with connect-udp)
* Make IP lists comma-separated instead of RFC 6570 list types.

Fixes #2713 and #2714
@bemasc bemasc mentioned this issue Feb 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bemasc bemasc

Labels
connect-tcp draft-ietf-httpbis-connect-tcp
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[connect-tcp] Define syntax more precisely httpwg/http-extensions
2 participants
@bemasc @DavidSchinazi