Add scala 3 support for uPickle, Jackson and Circe #757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
I missed a comma in my commits. build.sbt should be working now :) |
Get rid of private lazy val as this doesn't compile for Scala 3. ``` non-private method unmarshaller in trait UpickleCustomizationSupport refers to private lazy value apiInstance ``` by making the def api, a val, we work around this limitation
Do not use typetag for Jackson but classtag
Add missing comma
DieBauer
force-pushed
the
scala3-part2
branch
from
7e5539f
to
d04ba01
Compare
pjfanning
reviewed
Feb 24, 2023
| import scala.concurrent.Await | ||
| import scala.concurrent.duration.DurationInt | ||
|
|
||
| final class CirceSupportSpec2 |
There was a problem hiding this comment.
could you rename the file to CirceSupportSpec2.scala (likewise in scala-2 dir)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uPickle needed to get rid of a private lazy val.
Jackson got rid off the TypeTag, it seems ClassTag suffices.
Circe only has issues with the test and an implicit. This 'bug' is fixed in scala 3 and the specific test has been split up in scala-2 and scala-3 test sources.
This PR builds on top off #754 because some decisions have been made here to make the project compile for 3.
#755