New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pre-commit hooks for code checks #6407
base: develop
Are you sure you want to change the base?
Conversation
2a43844
to
0b54581
Compare
0b54581
to
db1f41d
Compare
Quality Gate passedIssues Measures |
@eternaltyro the build and push seems to fail, if reran. It did pass the first time i created this PR, but failed once i had more commits pushed to this branch. Just letting you know. |
@dakotabenjamin i have 3 of those commented since they messed up our code and autofix didn't work. Need more input from dev end on those. May be we should create new issues about that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
99% of the changes are extraneous newlines, spaces, and tabs. the other 1% look good and agree on the commented out files needing input from the other devs. great start! LGTM
What type of PR is this? (check all applicable)
Describe this PR
We had no mechanism to perform checks for the code that has been pushed as mentioned #5714 . Also since the integration of pre-commit.ci we have been facing checks failing due to lack of
pre-commit-config.yaml
within the project.Need of Further Investigation (β οΈ )
autofix
didn't fix all the issues so fronend team should have to look into depth. Currently is commented out.pretty-format-json
hook, that would format all json files, this caused tests to fail, i believe this is due to some test cases that wouldn't parse successfully. Needs more investigation from backend team, as just formatting the*.json
the tests shouldn't have failed.Screenshots