Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use hotosm/gh-workflows for container img builds #6374

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

spwoodcock
Copy link
Member

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation
  • πŸ§‘β€πŸ’» Refactor
  • βœ… Test
  • πŸ€– Build or CI
  • ❓ Other (please specify)

Describe this PR

@eternaltyro

  • This PR uses the hotosm/gh-workflows image build workflow for the backend.
  • Everything is preconfigured, including vulnerability scanning, correct tagging, ghcr registry caching, multi-arch builds (AMD64/ARM64).
  • The frontend can be built in a similar way, but as the tasking-manager.env is copied into the image, either:
    • The dockerfile would need to be updated to take ENV/ARG variables for everything instead.
    • The workflow would have to be updated to support copying the .env in during the build (no recommended).

Screenshots

Please provide screenshots of the change.

Alternative Approaches Considered

Did you attempt any other approaches that are not documented in code?

Review Guide

Notes for the reviewer. How to test this change?

Checklist before requesting a review

[optional] What gif best describes this PR or how it makes you feel?

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant