Skip to content

Commit

Permalink
Merge pull request #6430 from hotosm/fix/6429-mapbox-language-not-sup…
Browse files Browse the repository at this point in the history
…ported-error
  • Loading branch information
ramyaragupathy committed May 14, 2024
2 parents 2b5767a + 15f4ad9 commit 00120fd
Show file tree
Hide file tree
Showing 6 changed files with 40 additions and 14 deletions.
8 changes: 5 additions & 3 deletions frontend/src/components/projectCreate/projectCreationMap.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ import MapboxLanguage from '@mapbox/mapbox-gl-language';
import MapboxGeocoder from '@mapbox/mapbox-gl-geocoder';
import '@mapbox/mapbox-gl-geocoder/dist/mapbox-gl-geocoder.css';
import { useDropzone } from 'react-dropzone';

import { mapboxLayerDefn } from '../projects/projectsMap';
import useMapboxSupportedLanguage from '../../hooks/UseMapboxSupportedLanguage';

import {
MAPBOX_TOKEN,
Expand All @@ -31,7 +33,7 @@ try {

const ProjectCreationMap = ({ mapObj, setMapObj, metadata, updateMetadata, step, uploadFile }) => {
const mapRef = createRef();
const locale = useSelector((state) => state.preferences['locale']);
const mapboxSupportedLanguage = useMapboxSupportedLanguage();
const token = useSelector((state) => state.auth.token);
const [showProjectsAOILayer, setShowProjectsAOILayer] = useState(true);
const [aoiCanBeActivated, setAOICanBeActivated] = useState(false);
Expand Down Expand Up @@ -85,7 +87,7 @@ const ProjectCreationMap = ({ mapObj, setMapObj, metadata, updateMetadata, step,
attributionControl: false,
})
.addControl(new mapboxgl.AttributionControl({ compact: false }))
.addControl(new MapboxLanguage({ defaultLanguage: locale.substr(0, 2) || 'en' }))
.addControl(new MapboxLanguage({ defaultLanguage: mapboxSupportedLanguage }))
.addControl(new mapboxgl.ScaleControl({ unit: 'metric' }));
if (MAPBOX_TOKEN) {
map.addControl(
Expand All @@ -94,7 +96,7 @@ const ProjectCreationMap = ({ mapObj, setMapObj, metadata, updateMetadata, step,
mapboxgl: mapboxgl,
marker: false,
collapsed: true,
language: locale.substr(0, 2) || 'en',
language: mapboxSupportedLanguage,
}),
'top-right',
);
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/projectEdit/priorityAreasForm.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { useState, useContext, useLayoutEffect, createRef } from 'react';
import { useSelector } from 'react-redux';
import mapboxgl from 'mapbox-gl';
import 'mapbox-gl/dist/mapbox-gl.css';
import '@mapbox/mapbox-gl-draw/dist/mapbox-gl-draw.css';
Expand All @@ -25,6 +24,7 @@ import {
import { getErrorMsg } from '../projectCreate/fileUploadErrors';
import { Alert } from '../alert';
import WebglUnsupported from '../webglUnsupported';
import useMapboxSupportedLanguage from '../../hooks/UseMapboxSupportedLanguage';

mapboxgl.accessToken = MAPBOX_TOKEN;
try {
Expand All @@ -35,7 +35,7 @@ try {

export const PriorityAreasForm = () => {
const { projectInfo, setProjectInfo } = useContext(StateContext);
const locale = useSelector((state) => state.preferences['locale']);
const mapboxSupportedLanguage = useMapboxSupportedLanguage();
const mapRef = createRef();
const [error, setError] = useState({ error: false, message: null });

Expand Down Expand Up @@ -129,7 +129,7 @@ export const PriorityAreasForm = () => {
attributionControl: false,
})
.addControl(new mapboxgl.AttributionControl({ compact: false }))
.addControl(new MapboxLanguage({ defaultLanguage: locale.substr(0, 2) || 'en' }))
.addControl(new MapboxLanguage({ defaultLanguage: mapboxSupportedLanguage }))
.addControl(new mapboxgl.NavigationControl());

setMapObj({ ...mapObj, map: map });
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/projects/projectsMap.js
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { createRef, useLayoutEffect, useState, useCallback } from 'react';
import { useSelector } from 'react-redux';
import mapboxgl from 'mapbox-gl';
import 'mapbox-gl/dist/mapbox-gl.css';
import MapboxLanguage from '@mapbox/mapbox-gl-language';

import WebglUnsupported from '../webglUnsupported';
import { MAPBOX_TOKEN, MAP_STYLE, MAPBOX_RTL_PLUGIN_URL } from '../../config';
import mapMarker from '../../assets/img/mapMarker.png';
import useMapboxSupportedLanguage from '../../hooks/UseMapboxSupportedLanguage';

let markerIcon = new Image(17, 20);
markerIcon.src = mapMarker;
Expand Down Expand Up @@ -97,8 +97,8 @@ export const mapboxLayerDefn = (map, mapResults, clickOnProjectID, disablePoiCli

export const ProjectsMap = ({ mapResults, fullProjectsQuery, setQuery, className }) => {
const mapRef = createRef();
const locale = useSelector((state) => state.preferences['locale']);
const [map, setMapObj] = useState(null);
const mapboxSupportedLanguage = useMapboxSupportedLanguage();

const clickOnProjectID = useCallback(
(projectIdSearch) =>
Expand Down Expand Up @@ -131,7 +131,7 @@ export const ProjectsMap = ({ mapResults, fullProjectsQuery, setQuery, className
attributionControl: false,
})
.addControl(new mapboxgl.AttributionControl({ compact: false }))
.addControl(new MapboxLanguage({ defaultLanguage: locale.substr(0, 2) || 'en' })),
.addControl(new MapboxLanguage({ defaultLanguage: mapboxSupportedLanguage })),
);

return () => {
Expand Down
5 changes: 3 additions & 2 deletions frontend/src/components/taskSelection/map.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import messages from './messages';
import { MAPBOX_TOKEN, TASK_COLOURS, MAP_STYLE, MAPBOX_RTL_PLUGIN_URL } from '../../config';
import lock from '../../assets/img/lock.png';
import redlock from '../../assets/img/red-lock.png';
import useMapboxSupportedLanguage from '../../hooks/UseMapboxSupportedLanguage';

let lockIcon = new Image(17, 20);
lockIcon.src = lock;
Expand Down Expand Up @@ -42,7 +43,7 @@ export const TasksMap = ({
}) => {
const intl = useIntl();
const mapRef = createRef();
const locale = useSelector((state) => state.preferences['locale']);
const mapboxSupportedLanguage = useMapboxSupportedLanguage();
const authDetails = useSelector((state) => state.auth.userDetails);
const [hoveredTaskId, setHoveredTaskId] = useState(null);

Expand All @@ -62,7 +63,7 @@ export const TasksMap = ({
attributionControl: false,
})
.addControl(new mapboxgl.AttributionControl({ compact: false }))
.addControl(new MapboxLanguage({ defaultLanguage: locale.substr(0, 2) || 'en' })),
.addControl(new MapboxLanguage({ defaultLanguage: mapboxSupportedLanguage })),
);

return () => {
Expand Down
6 changes: 3 additions & 3 deletions frontend/src/components/userDetail/countriesMapped.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import { createRef, useLayoutEffect, useState } from 'react';
import { useSelector } from 'react-redux';
import { useNavigate } from 'react-router-dom';
import mapboxgl from 'mapbox-gl';
import MapboxLanguage from '@mapbox/mapbox-gl-language';
Expand All @@ -10,6 +9,7 @@ import { MAPBOX_TOKEN, MAP_STYLE, MAPBOX_RTL_PLUGIN_URL } from '../../config';
import { mapboxLayerDefn } from '../projects/projectsMap';
import { BarListChart } from './barListChart';
import WebglUnsupported from '../webglUnsupported';
import useMapboxSupportedLanguage from '../../hooks/UseMapboxSupportedLanguage';

mapboxgl.accessToken = MAPBOX_TOKEN;
try {
Expand All @@ -20,7 +20,7 @@ try {

const UserCountriesMap = ({ projects }) => {
const navigate = useNavigate();
const locale = useSelector((state) => state.preferences['locale']);
const mapboxSupportedLanguage = useMapboxSupportedLanguage();

const [map, setMap] = useState(null);
const mapRef = createRef();
Expand All @@ -36,7 +36,7 @@ const UserCountriesMap = ({ projects }) => {
attributionControl: false,
})
.addControl(new mapboxgl.AttributionControl({ compact: false }))
.addControl(new MapboxLanguage({ defaultLanguage: locale.substr(0, 2) || 'en' })),
.addControl(new MapboxLanguage({ defaultLanguage: mapboxSupportedLanguage })),
);

return () => {
Expand Down
23 changes: 23 additions & 0 deletions frontend/src/hooks/UseMapboxSupportedLanguage.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { useSelector } from 'react-redux';
import MapboxLanguage from '@mapbox/mapbox-gl-language';

const { supportedLanguages } = new MapboxLanguage();

const defaultLocale = 'en';

/**
* A React custom hook to check if the locale language is supported by Mapbox GL or not
*
* Returns `en` if the locale is not supported, else returns preferred locale
*
*/
export default function useMapboxSupportedLanguage() {
const locale = useSelector((state) => state.preferences.locale);

if (!locale) return defaultLocale;

const language = locale.substr(0, 2);
if (supportedLanguages.includes(language)) return language;

return defaultLocale;
}

0 comments on commit 00120fd

Please sign in to comment.