Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
HassJob.target
is annotated asCallable[_P, _R_co]
with a covariant return type. However, as a normal instance variable it's actuallyinvariant
which would be an error. At the moment both mypy and pyright don't enforce that though so it went unnoticed.With the upcoming support for PEP 695, the variance will be inferred dynamically. That's how I noticed the issue.
As it will be marked as
Final
, we can't applycast
and thus have to do that onhassjob
itself or addtype: ignore
comments.core/homeassistant/core.py
Lines 311 to 321 in cd8dac6
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: