-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number for output limit for apsystems integration #117522
base: dev
Are you sure you want to change the base?
Add number for output limit for apsystems integration #117522
Conversation
Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Will you add more number entities?
- How often do you want to update the number entities?
That's the catch: There will never be more number entities. That will stay the only one. The updates should take place every 10-15 seconds or so. |
Hmmmmm, would it make sense to just do 2 calls in the coordinator and return the combined output? This way the integration would be more consistent over platforms |
I mean, a single switch will be added as well. I personally would say that we should keep it simple by calling the api directly. These parts probably won't need a lot of changes over time. |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests:
@joostlek