Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaseEntity for apsystems integration #117514

Merged
merged 7 commits into from
Jun 3, 2024

Conversation

mawoka-myblock
Copy link
Contributor

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration (apsystems) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apsystems can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apsystems Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

homeassistant/components/apsystems/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/entity.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/entity.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/entity.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 16, 2024 07:12
@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 16, 2024 15:10
@home-assistant home-assistant bot requested a review from epenet May 16, 2024 15:11
@joostlek
Copy link
Member

I think epenet makes some valid comments, I personally don't like to just throw big data objects (like the config entry) in these tiny entities

@mawoka-myblock
Copy link
Contributor Author

I think epenet makes some valid comments, I personally don't like to just throw big data objects (like the config entry) in these tiny entities

Oh, completely missed the comments from epenet 🤦🏼. Regarding those big objects, if you say so, I'll address it, but I thought I'd do it as the Adguard integration did it.

@mawoka-myblock mawoka-myblock marked this pull request as draft May 16, 2024 15:18
@joostlek
Copy link
Member

Right, I only said Adguard because they were one of the first to have the ConfigEntry data implemented, but now I am looking at the rest and meh, I don't like it 😂

@mawoka-myblock
Copy link
Contributor Author

Right, I only said Adguard because they were one of the first to have the ConfigEntry data implemented, but now I am looking at the rest and meh, I don't like it 😂

No, I haven't chosen Adguard because of you, only because it's at the top in the folder and is pretty full-featured and pretty high quality.

@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 17, 2024 13:12
homeassistant/components/apsystems/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/entity.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/entity.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 17, 2024 13:46
@mawoka-myblock mawoka-myblock marked this pull request as ready for review May 17, 2024 15:07
@home-assistant home-assistant bot requested a review from epenet May 17, 2024 15:07
@mawoka-myblock
Copy link
Contributor Author

I would love to get this merged before the release so that users don't open issues because of an incomplete featureset.

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit c23ec96 into home-assistant:dev Jun 3, 2024
24 checks passed
@mawoka-myblock
Copy link
Contributor Author

Thanks for the review!

@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants