-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BaseEntity for apsystems integration #117514
Add BaseEntity for apsystems integration #117514
Conversation
Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
I think epenet makes some valid comments, I personally don't like to just throw big data objects (like the config entry) in these tiny entities |
Oh, completely missed the comments from epenet 🤦🏼. Regarding those big objects, if you say so, I'll address it, but I thought I'd do it as the Adguard integration did it. |
Right, I only said Adguard because they were one of the first to have the ConfigEntry data implemented, but now I am looking at the rest and meh, I don't like it 😂 |
No, I haven't chosen Adguard because of you, only because it's at the top in the folder and is pretty full-featured and pretty high quality. |
dde403d
to
e370bb2
Compare
I would love to get this merged before the release so that users don't open issues because of an incomplete featureset. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Thanks for the review! |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: