-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch client connection error in Honeywell #117502
Catch client connection error in Honeywell #117502
Conversation
Add config flow description
Hey there @rdfurman, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like two pull requests, as the changes in config_flow.py appear to have nothing to do with catching the client connection error during startup. If so, consider breaking this into two pull request.
Also the changes should be reflected in the tests for the integraiton.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me, though I'd prefer the minor formatting changes to config_flow.py to be in a seperate PR
Once I've touched the file, ruff reformatted it to the newer rules and won't let me put it back - might as well just accept the future at this point :) I know i can jump through hoops to rewind the commit... but is it really worth it? |
I'm ok with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Normally you would need to split the config flow changes to a new PR. But it's okay for this time. In the future please add unrelated changes to a new PR :)
Please add to the description that you improved the typing of the config flow
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Robert Resch <robert@resch.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mkmer 👍
Proposed change
Catch client connection error at startup (and retry)
Improve typing in config flow
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: