Add abilty to config cache size for dnsmasq addon #3601
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
WalkthroughWalkthroughThe Changes
Tip New Features and ImprovementsReview SettingsIntroduced new personality profiles for code reviews. Users can now select between "Chill" and "Assertive" review tones to tailor feedback styles according to their preferences. The "Assertive" profile posts more comments and nitpicks the code more aggressively, while the "Chill" profile is more relaxed and posts fewer comments. AST-based InstructionsCodeRabbit offers customizing reviews based on the Abstract Syntax Tree (AST) pattern matching. Read more about AST-based instructions in the documentation. Community-driven AST-based RulesWe are kicking off a community-driven initiative to create and share AST-based rules. Users can now contribute their AST-based rules to detect security vulnerabilities, code smells, and anti-patterns. Please see the ast-grep-essentials repository for more information. New Static Analysis ToolsWe are continually expanding our support for static analysis tools. We have added support for Tone SettingsUsers can now customize CodeRabbit to review code in the style of their favorite characters or personalities. Here are some of our favorite examples:
Revamped Settings PageWe have redesigned the settings page for a more intuitive layout, enabling users to find and adjust settings quickly. This change was long overdue; it not only improves the user experience but also allows our development team to add more settings in the future with ease. Going forward, the changes to Miscellaneous
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Additional Context UsedLanguageTool (23)
Markdownlint (2)
Path-based Instructions (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Outside diff range and nitpick comments (4)
dnsmasq/DOCS.md (4)
Line range hint
47-47: Correct the phrase for clarity and consistency.- By default it is configured to have Google's public DNS servers: `"8.8.8.8", "8.8.4.4"`. + By default, it is configured to use Google's public DNS servers: `"8.8.8.8", "8.8.4.4"`.Adding a comma after "By default" improves the readability, and changing "have" to "use" makes the sentence more direct.
Line range hint
50-50: Correct abbreviation usage.- Port can be specified using # separator, eg. `"192.168.1.2#1053"` + Port can be specified using # separator, e.g., `"192.168.1.2#1053"`The abbreviation "e.g." should be followed by a comma for correct usage.
Line range hint
72-72: Use the correct indefinite article.- to resolve directly to a internal IP address, e.g., `192.168.1.10`. + to resolve directly to an internal IP address, e.g., `192.168.1.10`."An" should be used instead of "a" before words that start with a vowel sound.
Line range hint
73-73: Simplify the phrase for clarity.- While outside of this network, it would resolve normally. + Outside this network, it resolves normally.This change removes redundancy and makes the instruction more direct.
| ### Option: `cache_size` | ||
|
|
||
| Sets the size of the Dnsmasq cache. The default setting is 150. If this is set to 0 this disables caching. Note that huge cache sizes can create performance problems. | ||
|
|
There was a problem hiding this comment.
Clarify the implications of setting cache_size to 0.
- If this is set to 0 this disables caching.
+ Setting this to 0 disables caching.This change makes the sentence more direct and authoritative, aligning with the documentation style guidelines.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| ### Option: `cache_size` | |
| Sets the size of the Dnsmasq cache. The default setting is 150. If this is set to 0 this disables caching. Note that huge cache sizes can create performance problems. | |
| ### Option: `cache_size` | |
| Sets the size of the Dnsmasq cache. The default setting is 150. Setting this to 0 disables caching. Note that huge cache sizes can create performance problems. |
|
The option is cache-size not cache. Are we not even spinning up the add-on for a sanity check as part of our testing process? |
This adds the ability to set the cache size for the Dnsmasq addon.
The default cache size is 150, which can be too small when one has a lot of local servers and devices constantly calling out to cloud services. Here is a user request for adjusting the cache size https://community.home-assistant.io/t/dnsmasq-increase-cache-size/382020
Summary by CodeRabbit
New Features
cache_sizeallowing users to set the size of the Dnsmasq cache, enhancing caching performance.Updates