Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Route Search Remark #182

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

LOOHP
Copy link
Contributor

@LOOHP LOOHP commented May 15, 2024

Changes the "route remark" underneath each route in the search screen from the first stop to the difference between itself and the main line.

Continuation of #142.

@LOOHP LOOHP mentioned this pull request May 15, 2024
@thomas930
Copy link
Contributor

It's great if screenshot can be shown.

@chunlaw
Copy link
Member

chunlaw commented May 20, 2024

image

Some routes are now missing the origin, would it be better to add them back?

@LOOHP
Copy link
Contributor Author

LOOHP commented May 21, 2024

The idea of this change is to only display differences between special routes with their main routes. Since the main route doesn't have any differences with itself, there is no remark.
It could be changed to fallback to displaying the origin if there are no remarks if it is decided that that is better.

@chunlaw
Copy link
Member

chunlaw commented May 29, 2024

The idea of this change is to only display differences between special routes with their main routes. Since the main route doesn't have any differences with itself, there is no remark. It could be changed to fallback to displaying the origin if there are no remarks if it is decided that that is better.

Might you please apply the fallback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants