Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement #9 Export Current Block To a File #120

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

zeltrex7
Copy link

@zeltrex7 zeltrex7 commented Jan 3, 2024

#9 Added the button at the top right corner to download content of block to a file

Screenshot 2024-01-03 205750

@zeltrex7 zeltrex7 changed the title Issue #9 Export Current Block To a File Enhancement #9 Export Current Block To a File Jan 3, 2024
@heyman
Copy link
Owner

heyman commented Jan 4, 2024

Hi!

I don't want to merge the UI changes (e.g. download buttons, fontawesome dependency). I'd like the feature to be implemented as an exportCurrentBlock command that can be invoked through Menu -> Block -> Export Current Block.

There should probably be a call to revokeObjectURL somewhere.

This PR also includes unrelated changes (e.g. electron-builder version change, indentation changes).

@zeltrex7
Copy link
Author

zeltrex7 commented Jan 9, 2024

@heyman will try to build that way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants