Changes necessary to compile on arch linux (py38) #45
+88
−138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some necessary changes to compile pptk and create a wheel file for me on Arch Linux with Python 3.8. This solves both #37 and #39. I have tried to ignore the Windows and Apple sections and leave them mostly alone, but I would not expect this to work on those platforms without more modifications. Hopefully someone can expand my work and address those issues.
Here is the wheel file for convenience:
pptk-0.1.1-cp38-none-manylinux2014_x86_64.zip
To solve issue #39:
Removed old Find*.cmake files to use the ones provided by the
system packages, and made necessary changes to multiple
CMakeLists.txt to use those. Switched to imported targets.
Changed imports of numpy heders in cpp files to be compatible with the
folder structure provided by system packages.
To solve #37:
Modified setup.py to be compatible with pip 20.
Feedback would be appreciated, especially if this compiles on other systems. @victoriousluser I hope you can use this to add a wheel file to PyPI?