Additional keyword support in openvpn lens #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New --- up plugin ping ping-restart ping-timer-rem http-proxy now also supports authentication.
jamesjuran
force-pushed
the
openvpn_new_params
branch
from
fa1f151
to
2845769
Compare
|
Thanks for the patch. Could you add some tests in lenses/tests/test_openvpn.aug that check that these directives are processed as expected ? |
|
@jamesjuran any news on the tests for this? |
|
I'd like to, but it will probably be a while before I have time to do this, and my immediate problem is solved. If someone else would like to do the tests to help get this committed, please go ahead. |
|
@jamesjuran are you still interested in finishing this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the following keywords:
up
plugin
ping
ping-restart
ping-timer-rem
Also adds authentication support to http-proxy keyword.