add inlay hints lsp-test support #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelpj
approved these changes
May 17, 2024
| getAndResolveInlayHints :: TextDocumentIdentifier -> Range -> Session [InlayHint] | ||
| getAndResolveInlayHints tId range = do | ||
| inlayHints <- getInlayHints tId range | ||
| for inlayHints $ \inlayHint -> if isJust (inlayHint ^. L.data_) then resolveInlayHint inlayHint else pure inlayHint |
There was a problem hiding this comment.
Hmm, this should probably actually check the server capability for resolving inlay hints, same where we do this for other resolution things. I can't remember whether it's easy to get the server capabilities in lsp-test, so okay to leave it like this for now unless you feel like fixing it. I'll make an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
new:
getInlayHintsgetAndResolveInlayHintsresolveInlayHint(helper)