Fix renaming data constructors with fields (resolves #2915, resolves #4083) #4089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fendor
approved these changes
Mar 2, 2024
jhrcek
force-pushed
the
jhrcek/rename-data-constructors-with-fields
branch
from
a91e355
to
6d8dfd1
Compare
|
I'm turning this back to draft, because @michaelpj pointed out that ignoring GeneratedInfo in HieAST could lead to some issue down the line (where we ignore something that shouldn't be ignored) and he proposed an alternative approach to avoiding renaming things that should not be renamed: namely validating that each Range being renamed actually contains the Text corresponding to the old name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only works for renaming across single file.
To make the multi-file scenario work, we'll need something like wz1000/HieDb#73