-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MHS as a recognized compiler. #9878
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need additional code for compiler support? (cf. Distribution.Simple.{GHC,HaskellSuite,…}
)
I don't care about additional code right now. I just want to have mhs be recognized as a valid Haskell compiler to be used in .cabal files. To build things with mhs I use mcabal anyway. |
Looks like a hash needs to be updated:
|
Let me rebase to verify CI passes after we worked around the github changes breakage. |
@mergify rebase |
✅ Branch has been successfully rebased |
Actually, @geekosaur was right all along --- the hashes need to be updated to the ones given in https://github.com/haskell/cabal/actions/runs/8908155162/job/24463289224?pr=9878. @augustss: I'm afraid that's the task of the PR author. We'd also need a tiny changelog file: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog. I think, we can skip a test in this case, but it never hurts to add one. Thank you for the PR! |
The title says it all.