Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MHS as a recognized compiler. #9878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

augustss
Copy link

@augustss augustss commented Apr 9, 2024

The title says it all.

Copy link
Collaborator

@geekosaur geekosaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need additional code for compiler support? (cf. Distribution.Simple.{GHC,HaskellSuite,…})

@augustss
Copy link
Author

augustss commented Apr 9, 2024

I don't care about additional code right now. I just want to have mhs be recognized as a valid Haskell compiler to be used in .cabal files.

To build things with mhs I use mcabal anyway.

@geekosaur
Copy link
Collaborator

Looks like a hash needs to be updated:

  Distribution.Utils.Structured
    GenericPackageDescription:                                           FAIL (0.02s)
      tests/UnitTests/Distribution/Utils/Structured.hs:31:
      expected: 5a48c6570cbcf96af4c51f38962e37b5
       but got: f6306d42af1d4f88b269cbd6a7879e6d
      Use -p '/Distribution.Utils.Structured.GenericPackageDescription/' to rerun this test only.
    LocalBuildInfo:                                                      FAIL (0.02s)
      tests/UnitTests/Distribution/Utils/Structured.hs:31:
      expected: 6d668de33d7b4d5df3830e65e6941373
       but got: 214d441d7d9bf881624984de13980b37
      Use -p '/LocalBuildInfo/' to rerun this test only.

@Mikolaj
Copy link
Member

Mikolaj commented May 1, 2024

Let me rebase to verify CI passes after we worked around the github changes breakage.

@Mikolaj
Copy link
Member

Mikolaj commented May 1, 2024

@mergify rebase

Copy link
Contributor

mergify bot commented May 1, 2024

rebase

✅ Branch has been successfully rebased

@Mikolaj
Copy link
Member

Mikolaj commented May 1, 2024

Actually, @geekosaur was right all along --- the hashes need to be updated to the ones given in https://github.com/haskell/cabal/actions/runs/8908155162/job/24463289224?pr=9878. @augustss: I'm afraid that's the task of the PR author. We'd also need a tiny changelog file: https://github.com/haskell/cabal/blob/master/CONTRIBUTING.md#changelog. I think, we can skip a test in this case, but it never hurts to add one. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
attention: needs-review re: --with-compiler Concerning option `-w` and similar
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants