Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken link in architecture.md #35184 #35185

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

jwhitt3r
Copy link
Contributor

@jwhitt3r jwhitt3r commented May 18, 2024

Description
The link goes to a broken package in pkg, this PR resolves the bug by updating the spelling of the link to appropriately go to the correct location within the architecture.md . This PR fixes issue #35184.

Fix proposal
The link in question that is broken is:
https://pkg.go.dev/github.com/hashicorp/terraform/internal/erraform#Execute
this is fixed with
https://pkg.go.dev/github.com/hashicorp/terraform/internal/terraform#Execute

Version
Fixes documentation in the current version # 1.8.3

terraform.exe --version
Terraform v1.8.3
on windows_amd64

Change log entry
BUG FIX

  • broken link within architecture.md updated to correct location

Updated a broken link due to spelling mistake
Copy link

hashicorp-cla-app bot commented May 18, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

@crw
Copy link
Collaborator

crw commented May 21, 2024

Thanks for fixing this link. Unfortunately the documentation is still not displayed due to the BUSL license change, apparently, but at least this link is now fixed.

@jwhitt3r
Copy link
Contributor Author

jwhitt3r commented May 21, 2024

Thanks for fixing this link. Unfortunately the documentation is still not displayed due to the BUSL license change, apparently, but at least this link is now fixed.

Hay not a problem at all, yea I used the license page as my north star! Thanks for reviewing. Any issues let me know.

@crw crw merged commit 433bed2 into hashicorp:main May 21, 2024
5 of 6 checks passed
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@jwhitt3r jwhitt3r deleted the jwhitt3r-patch-1 branch May 24, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants