Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Delete Expunge removes corresponding HFJ_RES_SEARCH_URL records for affected resources #5940

Conversation

lukedegruchy
Copy link
Collaborator

@lukedegruchy lukedegruchy commented May 15, 2024

  • Add delete HFJ_RES_SEARCH_URL SQLs to the ones run by DeleteExpungeSvcImpl
  • Add a foreign key to HFJ_RES_SEARCH_URL linking to HFJ_RESOURCE both in the entity definition and to the migration tasks
  • Enhance existing tests to assert the new behaviour

Closes #5942

…d a new foreign key on RES_ID to HFJ_RESOURCE to HFJ_RES_SEARCH_URL. Add a migration task to set up the new FK.
Copy link

github-actions bot commented May 15, 2024

Formatting check succeeded!

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.44%. Comparing base (497b9f2) to head (7031716).
Report is 67 commits behind head on master.

Current head 7031716 differs from pull request most recent head 1adb64e

Please upload reports for the commit 1adb64e to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5940      +/-   ##
============================================
+ Coverage     83.39%   83.44%   +0.04%     
- Complexity    26927    27087     +160     
============================================
  Files          1681     1692      +11     
  Lines        103965   104563     +598     
  Branches      13189    13235      +46     
============================================
+ Hits          86702    87250     +548     
- Misses        11613    11647      +34     
- Partials       5650     5666      +16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukedegruchy lukedegruchy changed the title Delete HFJ_RES_SEARCH_URL record when delete expunging a resource. A… Ensure Delete Expunge removes corresponding HFJ_RES_SEARCH_URL records for affected resources May 16, 2024
@lukedegruchy lukedegruchy marked this pull request as ready for review May 16, 2024 15:44
@lukedegruchy lukedegruchy requested a review from a team as a code owner May 16, 2024 15:44
@lukedegruchy lukedegruchy enabled auto-merge (squash) May 21, 2024 14:10
Copy link
Contributor

@michaelabuckley michaelabuckley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration + fk definition look good.
I question the need to keep both the id field and the entity field in the entity.

@lukedegruchy lukedegruchy enabled auto-merge (squash) May 22, 2024 17:34
@lukedegruchy lukedegruchy merged commit 0fe3380 into master May 22, 2024
63 of 64 checks passed
@lukedegruchy lukedegruchy deleted the ld-20240515-cda-plus-delete-expunge-reimport-fails-res-search-url branch May 22, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete corresponding HFJ_RES_SEARCH_URL records when performing a delete expunge on resources
3 participants