-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Delete Expunge removes corresponding HFJ_RES_SEARCH_URL records for affected resources #5940
Ensure Delete Expunge removes corresponding HFJ_RES_SEARCH_URL records for affected resources #5940
Conversation
…d a new foreign key on RES_ID to HFJ_RESOURCE to HFJ_RES_SEARCH_URL. Add a migration task to set up the new FK.
Formatting check succeeded! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5940 +/- ##
============================================
+ Coverage 83.39% 83.44% +0.04%
- Complexity 26927 27087 +160
============================================
Files 1681 1692 +11
Lines 103965 104563 +598
Branches 13189 13235 +46
============================================
+ Hits 86702 87250 +548
- Misses 11613 11647 +34
- Partials 5650 5666 +16 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The migration + fk definition look good.
I question the need to keep both the id field and the entity field in the entity.
Closes #5942