Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Subscription Settings from Storage Settings #5887

Open
wants to merge 22 commits into
base: master
Choose a base branch
from

Conversation

fil512
Copy link
Collaborator

@fil512 fil512 commented Apr 30, 2024

Extract Subscription Settings from Storage Settings so they can be managed independently.

Copy link

github-actions bot commented Apr 30, 2024

Formatting check succeeded!

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.43%. Comparing base (497b9f2) to head (9bbc44a).
Report is 88 commits behind head on master.

Current head 9bbc44a differs from pull request most recent head 37bb778

Please upload reports for the commit 37bb778 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5887      +/-   ##
============================================
+ Coverage     83.39%   83.43%   +0.04%     
- Complexity    26927    27118     +191     
============================================
  Files          1681     1696      +15     
  Lines        103965   104718     +753     
  Branches      13189    13269      +80     
============================================
+ Hits          86702    87375     +673     
- Misses        11613    11646      +33     
- Partials       5650     5697      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fil512 fil512 changed the title Config cleanup Extract Subscription Settings from Storage Settings Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant