Solving #109 with redundant inclusion guards #110
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To reduce compilation time explodes in ctre.hpp
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
added CTRE_V2__CTLL__HPP redundant guard
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
To reduce compilation time explodes
|
Do you have some measurements? This seems really sketchy. |
|
Ok, I read the book on pages you sent, the chapter is talking about preprocessor, not about templates. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using redundant include guards to minimize the compilation time
C Preprocessor inclusions could explode the compilation time (even with pragma once!)
The basic idea comes from an old, dusty C++ book called Large Scale C++ Software Design, page 83-88.
Expanding the
evaluatemethod indicated in the issue #109, everytime the?in0?1?2?3?4?5?6?7?8?9?is parsed, a new template instantiation begins, reading all the files again in the#includes, and increasing exponentially the compilation time.I didn't use any redundant include guards in the standard header files. They could be used into them, too, in order to reduce even more the compilation times.
Test case:
0?1?2?3?4?5?6?7?8?9?Even worst compile time test case:
a?b?c?d?e?f?g?h?i?j?l?m?n?o?p?q?r?s?t?u?v?w?x?y?z?