fix: deleting selected text in a list with the backspace key causes the list to revert #5938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
kind/bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5938 +/- ##
============================================
- Coverage 56.91% 56.61% -0.31%
- Complexity 3319 3468 +149
============================================
Files 587 612 +25
Lines 18968 20528 +1560
Branches 1401 1419 +18
============================================
+ Hits 10795 11621 +826
- Misses 7594 8323 +729
- Partials 579 584 +5 ☔ View full report in Codecov by Sentry. |
|
JohnNiang
approved these changes
May 21, 2024
f2c-ci-robot
bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang, ruibaby The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/area editor
/milestone 2.16.x
What this PR does / why we need it:
移除使用
Backspace进行缩进的功能。此功能会导致选中无序列表文本至起始位置时，按Backspace快捷键会导致无序列表解除当前层级。How to test it?
测试从后往前选中无序列表文本至文本起始位置，然后按下
Backspace快捷键。此时应当只删除文本而不会调整无序列表层级。Which issue(s) this PR fixes:
Fixes #5925
Does this PR introduce a user-facing change?