New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support loading ESM modules using ui.script #2331 #2332

Merged

mturoci merged 2 commits into main from feat/issue-2331

May 21, 2024

Contributor

marek-mihok commented May 15, 2024 •

edited

The PR fulfills these requirements: (check all the apply)

It's submitted to the main branch.
When resolving a specific issue, it's referenced in the PR's title (e.g. feat: Add a button #xxx, where "xxx" is the issue number).
When resolving a specific issue, the PR description includes Closes #xxx, where "xxx" is the issue number.
If changes were made to ui folder, unit tests (make test) still pass.
New/updated tests are included

Adds type attribute to ui.script(). Tested manually - it loads JavaScript modules properly when type="module" is specified.

Closes #2331

marek-mihok added 2 commits

May 15, 2024 17:07


          feat: add type attribute to ui.script #2331

40a481e


          chore: update docs #2331

8ace2a6

marek-mihok marked this pull request as ready for review

May 17, 2024 15:37

marek-mihok requested review from lo5 and mturoci as code owners

May 17, 2024 15:37

mturoci approved these changes

View reviewed changes

Collaborator

mturoci left a comment

LGTM, good job @marek-mihok!

mturoci merged commit 5a1953f into main

mturoci deleted the feat/issue-2331 branch

May 21, 2024 07:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment