update jarjar tool to work with libs compiled with newer java versions #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niloc132
reviewed
Mar 4, 2024
vegegoku
force-pushed
the
update-jarjar-tool
branch
3 times, most recently
from
8dc21cb
to
e893b66
Compare
vegegoku
force-pushed
the
update-jarjar-tool
branch
from
e893b66
to
3256452
Compare
niloc132
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of jarjar provided in the repo cant process jars compiled with newer java versions, for example it works for guava-19.0 but no longer works with guava-23.0 or above, this PR updates the jar with a version that uses a newer version of asm to support libs built with newer java version.