Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #9778 #9785

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fixes #9778 #9785

wants to merge 3 commits into from

Conversation

rjeeb
Copy link

@rjeeb rjeeb commented Nov 11, 2022

Excluding the pom.xml file from rebased protobuf-java-rebased-2.5.0.jar.

The fix excludes the pom file from the jar to ensure that dependency check libraries don't deal with it as usual protobuf-java dependency. It was tested on a project with jeremylong dependency check maven plugin and the result attached has no vulnerability on protobuf-java.

dependency-check-report.zip

@niloc132
Copy link
Contributor

Thanks for this patch.

I've deployed a build of this to https://repo.vertispan.com/gwt-snapshot/ with version 2.11.0-fix-9778-SNAPSHOT. This uses the new groupIds, org.gwtproject:gwt-servlet:2.11.0-fix-9778-SNAPSHOT.

For example, see https://repo.vertispan.com/gwt-snapshot/org/gwtproject/gwt-servlet/2.11.0-fix-9778-SNAPSHOT/ to get the gwt-servlet jar.

@zbynek
Copy link
Contributor

zbynek commented Mar 17, 2023

This should fix #9778 , #9790 and #9752

@niloc132
Copy link
Contributor

niloc132 commented Mar 1, 2024

If anyone can report back that they've tested this and confirmed it removes the false positive, we can see about merging it. That said, another change is in progress to update the sourcemap support so that gwt-servlet.jar doesn't use protobuf at all anyway, so these issues will be resolved in 2.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants