Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify build, support Java 11, cleanup readme #11

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

niloc132
Copy link
Contributor

@niloc132 niloc132 commented Mar 5, 2023

With the app no longer including server components, this content could be merged into gwt-site itself, or could be kept separate to avoid rebuilding each time the markdown is rendered to html. This change keeps the UI separate, but it is no longer required to already have the markdown rendered to HTML to build this. To ease development, a profile exists to combine the content and JS.

Updates to ltgt gwt-maven-plugin and GWT 2.9. Until GQuery is either updated or dropped, GWT 2.10+ cannot be used.

@niloc132
Copy link
Contributor Author

niloc132 commented Mar 5, 2023

Build summary, with downloadable generated JS https://github.com/niloc132/gwt-site-webapp/actions/runs/4338262581

Copy link
Contributor Author

@niloc132 niloc132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't going to work after all, I will try breaking it down into smaller pieces.

Specifically, the gwtquery upgrade has broken the expand/collapse menu icons, apparently 1.4.2 vs 1.5-beta1 changes at least one thing about how this works (two bugs observed, the content doesn't animate in as the content becomes visible, and the icons are reverse of what they are supposed to be (that is, when "open" the icon is pointing the correct direction and all are open by default, but contents are hidden).

However, in order to use newer GWT we need 1.5-beta1 (and there was never a stable release of 1.5).

@niloc132 niloc132 marked this pull request as draft March 5, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant