Update README.md #25
Open
Update README.md #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)
niloc132
reviewed
Mar 30, 2023
README.md
Outdated
| @@ -137,6 +138,7 @@ public class PersonComponent implements IsElement<HTMLDivElement>, Editor<Person | |||
|
|
|||
| private DominoElement<HTMLDivElement> root = DominoElement.of(div()); | |||
|
|
|||
| //Note: Do not create getter/setters for these fields - it will cause a compile issue such as "java.lang.IllegalStateException: generation aborted! No getter exists for >>getId<< -> [Help 1]" | |||
There was a problem hiding this comment.
probably we should have a bug report for this?
There was a problem hiding this comment.
Great feedback - updated thank you!
There was a problem hiding this comment.
I don't think, that there is a problem with the example. Please, take a look at my comment inside the issue.
README.md
Outdated
| @@ -129,6 +129,7 @@ public class Person { | |||
| > this component uses domino-ui | |||
|
|
|||
| ```java | |||
| //Note place in *-client directory | |||
There was a problem hiding this comment.
maybe specify "client project or package", since not all projects follow that archetype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)