Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3484 (V1) - Updates SDK version to dotnet8, adds netstandard2.0 and net8.0 TargetFrameworks #3486

Merged
merged 14 commits into from
May 29, 2024

Conversation

tig
Copy link
Collaborator

@tig tig commented May 20, 2024

Fixes

Todos

  • Changes global.config to use dotnet8
  • Adds netstandard2.0 to TFMs
  • Adds net8.0 to TFMs
  • Fixes warning in Clipboard.cs
  • Updates nuget packages

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig mentioned this pull request May 20, 2024
@dodexahedron
Copy link
Collaborator

I would suggest adding, not replacing, the target for net8.0, because .net 7 projects will grab the netstandard version if there's not a package targeting 7.

@dodexahedron
Copy link
Collaborator

dodexahedron commented May 21, 2024

And actually, unless it causes build errors, dropping 2.1 to 2.0 will enable framework projects to load the netstandard version as well. 2.1 was for Mono and added some goodies, but didn't get backported to .net framework.

If that does cause build errors, then of course leave 2.1 there for Mono peeps.

But we probably shouldn't be breaking compatibility with existing systems for any changes made to v1 til it's fully retired.

And adding multiple TFMs, if not build-breaking, costs us nothing. If an actual runtime issue crops up, we get to just say "sorry - not supported on EoL SDKs. Use at your own risk."

@tig tig changed the title V1 - Fixes #3484 - Updates SDK version to dotnet8 Fixes #3484 (V1) - Updates SDK version to dotnet8, adds netstandard2.0 and net8.0 TargetFrameworks May 21, 2024
@tig tig merged commit 0db120d into gui-cs:develop May 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET 8 support for v1.xxx
2 participants