Base.copy(::CellDatum) to copy solutions #841
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copy should copy the necessary data to make an independent copy of CellFields solution data (e.g. dof and dirichlet values), useful to save FEM solution modified in place (e.g. by TransientFESolution iterator). It does not copy geometry related data (e.g. CellPoint is not copied, just returned), those could be modified from the original instance.
Codecov Report
@@ Coverage Diff @@
## master #841 +/- ##
==========================================
- Coverage 88.33% 88.22% -0.11%
==========================================
Files 164 164
Lines 19109 19141 +32
==========================================
+ Hits 16879 16888 +9
- Misses 2230 2253 +23
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #827,
This copy should copy the necessary data to make an independent copy of CellFields solution data (e.g. dof, free, dirichlet values), useful to save FEM solution to prevent loss due to in place modification (e.g. by TransientFESolution iterator). It does not copy geometry related data (e.g. CellPoint is not copied, just returned), those could be modified from the original instance.
Potential flow :
I would appreciate any feedback on how to make this PR better !