Canvas: Adhere editing state to dashboard editable state #87883
Conversation
nmarrs
added
area/panel/canvas
nmarrs
requested review from
Develer and
adela-almasan
and removed request for
a team
| const dashboard = getDashboardSrv().getCurrent(); | ||
| const allowEditing = this.props.options.inlineEditing && dashboard?.editable; | ||
|
|
There was a problem hiding this comment.
editable is not the same as isEditing,
There was a problem hiding this comment.
but you could add a new property isEditing on DashboardModelCompatibilityWrapper if you want
There was a problem hiding this comment.
In its current form this PR addresses the legacy dashboard case which I think is still worth addressing as dashboard scenes is still in public preview
Created this follow up GitHub issue to address figuring this out for new dashboards based on scenes. I think for this to work as expected I think the dashboard scene will need to emit a state update (like editing is turned off / on) that a panel can listen to and respond to accordingly
|
Thanks for the quick fix! (I reported it to @leventebalogh on Slack) |
Adhere canvas editing state to dashboard's editable state. Before if the dashboard was read-only, users could still modify the canvas but would then have no way to save those changes.
Note: this approach will need to be updated for dashboard scene migration, but given as that is currently in public preview it makes sense to fix classic dashboards for the time being
See this follow up GitHub issue
Before
Screen.Recording.2024-05-07.at.15.27.59.mov
After
after.mov
Fixes #87446