XY Chart: Manual mode series naming #87879
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adela-almasan
added
area/panel/xychart
no-backport
adela-almasan
requested review from
codeincarnate and
nmarrs
and removed request for
a team
baldm0mma
reviewed
May 15, 2024
| series.forEach((xySeries, idx) => { | ||
| if (xySeries.name.value === xySeries.y.field.name) { | ||
| xySeries.name.value = `Series ${idx + 1}`; | ||
| } |
There was a problem hiding this comment.
Is there a sad-path for this inner if condition? Does there need to be one?
|
Postponing this as it needs more investigation. Moved issue to backlog. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Naming updated to
Series{idx}if the series name is matching the y field name.Fixes issue with fields disappearing in
automode.Before
xy_before.mov
After
xy_after.mov
Fixes #85032
Please check that: