Unified Storage: Modify handler metric label when for grafana api server #87851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s/{kind} instead of /apis/*
owensmallwood
requested review from
leonorfmartins
and removed request for
a team
ryantxu
reviewed
May 15, 2024
pkg/middleware/request_tracing.go
Outdated
| @@ -57,6 +57,14 @@ var unnamedHandlers = []struct { | |||
|
|
|||
| // RouteOperationName receives the route operation name from context, if set. | |||
| func RouteOperationName(req *http.Request) (string, bool) { | |||
| // all requests to the grafana k8s api server have a handler of /apis/*. This modifies that to be /apis/{kind}. | |||
There was a problem hiding this comment.
Suggested change
| // all requests to the grafana k8s api server have a handler of /apis/*. This modifies that to be /apis/{kind}. | |
| // all requests to the grafana k8s api server have a handler of /apis/*. This modifies that to be /apis/{group}. |
Kind (or resource) is later in the url
|
Closing bc we already have apiserver metrics |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting request metrics, all requests to the grafana apiserver have a handler label of
/apis/*.We need to be able to gather request metrics per group, so I changed the metrics middleware to modify the handler label from
/apis/*to/apis/{group}.