-
Notifications
You must be signed in to change notification settings - Fork 11.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update alert list visualization #87815
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great update! I've made some structural and wording suggestions.
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
docs/sources/panels-visualizations/visualizations/alert-list/index.md
Outdated
Show resolved
Hide resolved
This PR must be merged before a backport PR will be created. |
2 similar comments
This PR must be merged before a backport PR will be created. |
This PR must be merged before a backport PR will be created. |
Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (pending addition of video)!
@imatwawana I've added the video now, but the video is set to go live on the 22nd May :) |
@imatwawana All ready to be merged. Video is now live :) |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new branch
git switch --create backport-87815-to-v10.3.x origin/v10.3.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x 285567573e587360e3e6009029f80a26c1bc3d24 When the conflicts are resolved, stage and commit the changes:
If you have the GitHub CLI installed: # Push the branch to GitHub:
git push --set-upstream origin backport-87815-to-v10.3.x
# Create the PR body template
PR_BODY=$(gh pr view 87815 --json body --template 'Backport 285567573e587360e3e6009029f80a26c1bc3d24 from #87815{{ "\n\n---\n\n" }}{{ index . "body" }}')
# Create the PR on GitHub
echo "${PR_BODY}" | gh pr create --title '[v10.3.x] docs: update alert list visualization' --body-file - --label 'type/docs' --label 'no-changelog' --label 'backport' --base v10.3.x --milestone 10.3.x --web Or, if you don't have the GitHub CLI installed (we recommend you install it!): # Push the branch to GitHub:
git push --set-upstream origin backport-87815-to-v10.3.x
# Create a pull request where the `base` branch is `v10.3.x` and the `compare`/`head` branch is `backport-87815-to-v10.3.x`.
# Remove the local backport branch
git switch main
git branch -D backport-87815-to-v10.3.x |
* docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675)
* docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675)
docs: update alert list visualization (#87815) * docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675) Co-authored-by: Marie Cruz <mdcruz@users.noreply.github.com>
docs: update alert list visualization (#87815) * docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675) Co-authored-by: Marie Cruz <mdcruz@users.noreply.github.com>
* docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675)
docs: update alert list visualization (#87815) * docs: update alert list visualization * Apply suggestions from code review Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> * fix: linting errors * docs: add youtube video --------- Co-authored-by: Isabel Matwawana <76437239+imatwawana@users.noreply.github.com> (cherry picked from commit 2855675) Co-authored-by: Marie Cruz <mdcruz@users.noreply.github.com>
What is this feature?
Updates to the alert list visualization docs to include:
NOTE: Do not backport panel options shared file link to versions 10.3 and 10.4.
Why do we need this feature?
To explain to our users how to configure an alert list visualization easily and when to use it.
Who is this feature for?
Grafana OSS and Cloud users
Fixes #
Special notes for your reviewer:
Please check that: