Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Use TemplateSrv from @grafana/runtime in influxdb datasource #87813

Merged
merged 1 commit into from
May 15, 2024

Conversation

itsmylife
Copy link
Contributor

What is this feature?

Use TemplateSrv from @grafana/runtime. This is the first step to update VariableEditor. It will eventually help to handle #84120

@itsmylife itsmylife added datasource/InfluxDB type/chore no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 14, 2024
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 14, 2024
@itsmylife itsmylife marked this pull request as ready for review May 14, 2024 13:21
@itsmylife itsmylife requested a review from a team as a code owner May 14, 2024 13:21
@@ -257,125 +241,6 @@ describe('InfluxDataSource Frontend Mode [influxdbBackendMigration=false]', () =
expect(ds.database).toBe('fallback');
});
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were deleted because we were checking the cases interpolateQueryExpr suite.

Copy link
Contributor

@NWRichmond NWRichmond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and variables are working as expected. Thanks!

demo influxdb filters working as expected after refactor TemplateSrv

@itsmylife itsmylife merged commit 4fef6ff into main May 15, 2024
28 checks passed
@itsmylife itsmylife deleted the ismail/influxdb-templatesrv-update branch May 15, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend datasource/InfluxDB no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes type/chore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants