Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prometheus: Update dependency to v0.52.0 #87809

Merged
merged 11 commits into from
May 28, 2024
Merged

Prometheus: Update dependency to v0.52.0 #87809

merged 11 commits into from
May 28, 2024

Conversation

kylebrandt
Copy link
Contributor

What is this feature?

Upgrande promethues/prometheus dependency to v0.52.0

Why do we need this feature?

Support new native histogram function in the parser, which is hit when promQLScope feature flag is enabled.

Special notes for your reviewer:

  • Need alerting to verify that the changes in sender.go for service discovery are right, as I'm just copying what I see elsewhere and don't have the context.

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 14, 2024
@itsmylife
Merge branch 'refs/heads/main' into promUpgrade
08ad903 
# Conflicts:
#	go.mod
#	go.sum
#	go.work.sum
#	pkg/apiserver/go.mod
#	pkg/promlib/go.mod
#	pkg/promlib/go.sum
@itsmylife
go work sync
b6d1d28
@itsmylife
prometheus v0.52.0
a9ac230
@itsmylife
handle errors
706b270
santihernandezc
santihernandezc approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@santihernandezc santihernandezc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pkg/services/ngalert/sender/sender_test.go Outdated Show resolved Hide resolved
pkg/services/ngalert/sender/sender_test.go Outdated Show resolved Hide resolved
itsmylife and others added 2 commits May 27, 2024 16:35
@itsmylife @santihernandezc
Update pkg/services/ngalert/sender/sender_test.go
eb62ff4 
Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
@itsmylife @santihernandezc
Update pkg/services/ngalert/sender/sender_test.go
afcfc0e 
Co-authored-by: Santiago <santiagohernandez.1997@gmail.com>
@itsmylife itsmylife marked this pull request as ready for review May 27, 2024 14:35
@itsmylife itsmylife requested review from a team as code owners May 27, 2024 14:35
@itsmylife itsmylife requested review from jtheory, rwwiv, JacobsonMT, yuri-tceretian and grobinson-grafana and removed request for a team May 27, 2024 14:35
@itsmylife itsmylife added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels May 27, 2024
@itsmylife itsmylife merged commit a738cb4 into main May 28, 2024
22 checks passed
@itsmylife itsmylife deleted the promUpgrade branch May 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santihernandezc santihernandezc santihernandezc approved these changes

@jtheory jtheory Awaiting requested review from jtheory jtheory is a code owner automatically assigned from grafana/alerting-backend-product

@rwwiv rwwiv Awaiting requested review from rwwiv rwwiv is a code owner automatically assigned from grafana/alerting-backend-product

@JacobsonMT JacobsonMT Awaiting requested review from JacobsonMT JacobsonMT is a code owner automatically assigned from grafana/alerting-backend-product

@yuri-tceretian yuri-tceretian Awaiting requested review from yuri-tceretian yuri-tceretian is a code owner automatically assigned from grafana/alerting-backend-product

@grobinson-grafana grobinson-grafana Awaiting requested review from grobinson-grafana grobinson-grafana is a code owner automatically assigned from grafana/alerting-backend-product

Assignees

@itsmylife itsmylife

Labels
area/backend no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes
Projects
None yet
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kylebrandt @santihernandezc @itsmylife