Ensure JSON component outputs handled properly in postprocess #8292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-builds.s3.amazonaws.com/112cd5daaabd1e61230b266bfd2d44a230dc7ac3/gradio-4.31.2-py3-none-any.whlInstall Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@112cd5daaabd1e61230b266bfd2d44a230dc7ac3#subdirectory=client/python" |
🦄 change detectedThis Pull Request includes changes to the following packages.
With the following changelog entry.
Maintainers or the PR author can modify the PR title to modify this entry.
|
freddyaboulton
added
v: patch
freddyaboulton
force-pushed
the
add-json-data-model-event-data-cache
branch
from
f44e454
to
df12767
Compare
freddyaboulton
requested review from
whitphx,
abidlabs,
pngwn,
aliabid94,
aliabd,
dawoodkhan82 and
hannahblair
and removed request for
whitphx and
abidlabs
abidlabs
reviewed
May 15, 2024
| @@ -25,6 +25,8 @@ | |||
| from pydantic import BaseModel as BaseModelV1 | |||
| from pydantic import ValidationError, schema_of | |||
|
|
|||
| JsonValue = Any | |||
There was a problem hiding this comment.
We can be more specific no? Something like
Suggested change
| JsonValue = Any | |
| JsonValue = Union[Dict, List] |
abidlabs
reviewed
May 15, 2024
gradio/processing_utils.py
Outdated
| @@ -341,6 +342,24 @@ def move_resource_to_block_cache( | |||
| return block.move_resource_to_block_cache(url_or_file_path) | |||
|
|
|||
|
|
|||
| def is_file_obj(data: dict | JsonData): | |||
There was a problem hiding this comment.
Is this method only added for type-checking purposes? Because client_utils.is_file_obj already checks to see if data is a dict?
There was a problem hiding this comment.
Yea you're right another brain fart hehe
abidlabs
reviewed
May 15, 2024
test/components/test_json.py
Outdated
Comment on lines
98
to
99
| if postprocessed_value is None: | ||
| assert postprocessed_value is None |
There was a problem hiding this comment.
Brainfart - fixed!
abidlabs
approved these changes
May 15, 2024
There was a problem hiding this comment.
Thanks @freddyaboulton for taking care of this! Changes look good to me, left a couple of nits.
freddyaboulton
force-pushed
the
add-json-data-model-event-data-cache
branch
from
8fd0b6b
to
112cd5d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
EventDatainstances must only reference data in the cache🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Tests
PRs will only be merged if tests pass on CI. To run the tests locally, please set up your Gradio environment locally and run the tests:
bash scripts/run_all_tests.shYou may need to run the linters:
bash scripts/format_backend.shandbash scripts/format_frontend.sh