Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bigtable): Reject misspecified Automated Backup Policies when updating a table #10226

Merged
merged 6 commits into from
May 28, 2024
Merged

fix(bigtable): Reject misspecified Automated Backup Policies when updating a table #10226

merged 6 commits into from
May 28, 2024

Conversation

ma-g-22
Copy link
Contributor

@ma-g-22 ma-g-22 commented May 17, 2024 •
edited

UpdateTableWithAutomatedBackupPolicy should reject misspecified Automated Backup Policies, in particular when both the RetentionPeriod and Frequency are 0

@ma-g-22 ma-g-22 requested review from a team as code owners May 17, 2024 22:28
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label May 17, 2024
@ma-g-22 ma-g-22 mentioned this pull request May 21, 2024
Open
5 tasks
ma-g-22
ma-g-22 commented May 22, 2024
View reviewed changes
bigtable/admin.go Outdated Show resolved Hide resolved
@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 24, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 24, 2024
@ma-g-22 ma-g-22 mentioned this pull request May 28, 2024
Merged
@bhshkh bhshkh enabled auto-merge (squash) May 28, 2024 17:54
@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 28, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 28, 2024
@bhshkh bhshkh merged commit 84e45ce into googleapis:main May 28, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhshkh bhshkh bhshkh approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ma-g-22 @bhshkh @kokoro-team