Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix old versions of CMake erroneously reporting Intel LLVM as Clang #4541

Closed
wants to merge 1 commit into from

Conversation

tobbi
Copy link
Contributor

@tobbi tobbi commented May 14, 2024

This adds a check for the specific edge case of CMAKE versions less than 3.20 reporting Intel LLVM compilers as Clang.

I've verified this using the steps described in #4315 and it works just fine.

Fixes #4315

@tobbi tobbi force-pushed the fix-old-cmake--with-llvm branch from 2a968dd to c6346a1 Compare May 14, 2024 10:53
@derekmauro
Copy link
Member

Carrying a workaround for an unsupported platform is a maintenance burden. CMake itself doesn't even support this platform until 3.20. Here we are proposing working around an unsupported platform in a tool that doesn't support it either. Anyone serious about using CMake with IntelLLVM should just grab a copy of CMake that supports this.

@derekmauro derekmauro closed this May 22, 2024
@tobbi
Copy link
Contributor Author

tobbi commented May 22, 2024

Maybe it would help closing the original issue as well? It really is discouraging when you fix an issue that you ("Google") supposedly need help with only to be met with this message.

@derekmauro
Copy link
Member

Maybe it would help closing the original issue as well? It really is discouraging when you fix an issue that you ("Google") supposedly need help with only to be met with this message.

Sorry about that. I apologize for asking for help, but please realize that it wasn't until I saw your patch that I realized that it would have been best to just suggest upgrading CMake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Old CMake with IntelLLVM: Unsupported command line options, multiple warnings
2 participants