Adjust the code generated for enum types to avoid conflicting with names not reserved by the Flatbuffers IDL #8285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mes not reserved by the Flatbuffers IDL Fixes google#8052 The Flatbuffers IDL allows for enums to have values called "value", "values", "minValue" or "maxValue", but if these names are used for values in an enum, the generated Dart code won't compile. This modifies the Dart generator to use "$value", "$values", "$minValue" and "$maxValue" instead, so that valid Flatbuffer schemas can be used wth Dart
insertjokehere
force-pushed
the
8052-enum-name-conflict
branch
from
cf9549d
to
1b39351
Compare
vaind
reviewed
May 19, 2024
There was a problem hiding this comment.
Thanks for the contribution.
This is quite a breaking change - it would break anyone accessing these properties. Instead, I'd suggest changing the field name in case it conflicts, which would not break anyone because they couldn't have used that name anyway. That is what we do for conflicts with reserved keywords too (see uses of namer_).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8052
The Flatbuffers IDL allows for enums to have values called
value,values,minValueormaxValue, but if these names are used for values in an enum, the generated Dart code won't compile.This modifies the Dart generator to use
$value,$values,$minValueand$maxValueinstead, so that valid Flatbuffer schemas can be used with Dart