Added automatic publishing to crates.io on publish #8263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change secret name.
dbaileychess
previously approved these changes
May 29, 2024
remove extra space added in merge
dbaileychess
approved these changes
May 29, 2024
|
Thanks, meaning to get this in at some point. |
|
I manually ran a Release and get the following error. Mind if you can take a look? https://github.com/google/flatbuffers/actions/runs/9278729149/job/25530167137 |
|
@dbaileychess Oh! I must have missed a spot where I specified the relative directory of the crate. |
rdelfin
commented
Jun 4, 2024
Comment on lines
+136
to
+137
| run: | ||
| working-directory: ./rust |
There was a problem hiding this comment.
This should be enough to get it working though 🤔
There was a problem hiding this comment.
@dbaileychess: I think this needs to be ./rust/flatbuffers and maybe there needs to be a separate one for ./rust/flexbuffers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last few releases of the rust crate have not gotten published to crates.io, presumably as they still require publishing manually. This causes a mismatch in CLI and library versions that can introduce breaking changes which are only solvable by pulling in flatbuffer versions directly from github instead of going through crates.io, which is not ideal (see #8257).
This PR adds support for automatically publishing to the rust crates library using
katyo/publish-cratesgithub action. This will need adding the appropriate secrets from your side.Resolves #8257