vi: Translate Casting and Read/Write chapters from Std Trait session #2080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daivinhtran
reviewed
May 15, 2024
There was a problem hiding this comment.
Fanstatic translations, @vohoanglong0107 !
I have a few minor comments. Let me know once you fix them.
po/vi.po
Outdated
|
|
||
| #: src/std-traits/casting.md | ||
| msgid "This is common in casting integers to `usize` for use as an index." | ||
| msgstr "" | ||
| "Một trường hợp ngoại lệ là khi chuyển đổi số nguyên sang `usize` để sử dụng " |
There was a problem hiding this comment.
"common" isn't "ngoại lệ". should be "thông thường"?
There was a problem hiding this comment.
I would like to combine this translation to the above paragraph, forming:
Đối với những trường hợp ép kiểu có
thể thất bại, nên sử dụng `TryFrom` và `TryInto` để xử lý lỗi khi ép kiểu
(khi một giá trị không hoàn toàn phù hợp với kiểu dữ liệu đích).
Một trường hợp ngoại lệ là khi chuyển đổi số nguyên sang `usize` để sử dụng
làm index trong array
Do you think this is a good idea?
There was a problem hiding this comment.
Yeah that's fine for me.
mgeisler
changed the title
vohoanglong0107
force-pushed
the
vi-std-trait-casting-read-write
branch
from
bf2e23e
to
e1d3d55
Compare
qu-ngx
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small one. The final PR for
Std Traitsession will include theDefaultandClosureschapter, along with the session's exercises.