Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vi: block-n-scopes/...md translations #2073

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

HuyNVuong
Copy link
Contributor

No description provided.

Copy link
Contributor

@vohoanglong0107 vohoanglong0107 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the translation is really good, just left a few comment on some portion to make the translation clearer.

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved

#: src/control-flow-basics/blocks-and-scopes/scopes.md
msgid "\"inner scope: {a}\""
msgstr ""
msgstr "\"phạm vi bên trong: {a}\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know about this. What do you think @daivinhtran

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I'm not sure either. Can we keep it as inner scope?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daivinhtran I think we can still translate it to Vietnamese but put the English acronym in the brackets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will put the translation in the brackets like inner scope (phạm vi bên trong). We should translate as much as possible because our audience might know little to no English. It's not just hard to read but also hard to pronounce thus the translation so some one can refer to if they having a hard time reading it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HuyNVuong I agree with you. Either phạm vi bên trong (inner scope) or inner scope (phạm vi bên trong) is good I believe.

po/vi.po Outdated Show resolved Hide resolved
po/vi.po Outdated Show resolved Hide resolved
@HuyNVuong HuyNVuong requested a review from qu-ngx as a code owner May 31, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants