Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BaseRenderingContext2D.prototype.roundRect #4111

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

codyebberson
Copy link

@codyebberson codyebberson commented Aug 15, 2023

@h-joo h-joo self-requested a review August 16, 2023 15:16
@codyebberson
Copy link
Author

Hi @h-joo - anything I can do to improve this?

externs/browser/html5.js Outdated Show resolved Hide resolved
externs/browser/html5.js Show resolved Hide resolved
externs/browser/html5.js Show resolved Hide resolved
@codyebberson
Copy link
Author

codyebberson commented Sep 29, 2023

@niloc132 - thank you for the review

I added the function definition to the CanvasPathMethods as well. Good catch.

This now follows the exact same pattern as rect in CanvasPathMethods, BaseRenderingContext2D, and Path2D.

@codyebberson
Copy link
Author

Hi @h-joo and @niloc132 - Anything I can do to move this along?

@niloc132
Copy link
Contributor

Sorry, I'm just a contributor, I don't have any special powers to get patches merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants